Session start and end events #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidetofevil
approved these changes
May 31, 2024
breedx-splk
force-pushed
the
session_start_and_end_events
branch
from
2837df6 to
1ce116d
Compare
bidetofevil
reviewed
Jun 4, 2024
jsuereth
reviewed
Jun 7, 2024
2 tasks
joaopgrassi
approved these changes
Jun 13, 2024
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
|
@breedx-splk I think it would be good to have folks from the event and client working groups to take a look and approve this? Are you in touch with them? We don't seem to have a GitHub team for them so not sure how to get attention. |
MSNev
reviewed
Jul 9, 2024
LikeTheSalad
approved these changes
Jul 9, 2024
scheler
approved these changes
Jul 9, 2024
scheler
reviewed
Jul 10, 2024
lmolkova
reviewed
Jul 15, 2024
lmolkova
reviewed
Jul 15, 2024
Co-authored-by: Liudmila Molkova <[email protected]>
breedx-splk
commented
Jul 19, 2024
breedx-splk
commented
Jul 19, 2024
|
3 approvals, are we waiting for anything else on this? 🙏🏻 |
|
@breedx-splk please resolve open discussions (if they are resolved) and it should be ready to go |
lmolkova
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This serves as an alternative/successor to #1042. Instead of describing a session change event, we have a session start and session end event instead.
Merge requirement checklist
[chore]